This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Conversation
Contributor
|
In the PR title: s/remove/temporarily disable/ |
test_<service>_api_version_header_async which is not marked as async
test_<service>_api_version_header_async which is not marked as asynctest_<service>_api_version_header_async which is not marked as async
vchudnov-g
approved these changes
Aug 28, 2025
parthea
added a commit
that referenced
this pull request
Aug 28, 2025
…ich is not marked as async (#2429)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes 3 fixes to unblock development due to failing presubmits:
test_<service>_api_version_header_asyncwhich is not marked as async. See follow up issue Restore failing testtest_<service>_api_version_header_asyncgoogle-cloud-python#16218goldens-lintpresubmit as of mypy 1.16.0 #2410BEGIN_COMMIT_OVERRIDE
fix: Temporarily disable
test_<service>_api_version_header_asyncwhich is not marked as asynctest: Temporarily pin mypy<1.16.0
test: Temporarily pin pytest-asyncio<1.0.0
END_COMMIT_OVERRIDE